[SVN] [P.Smasher] OSI party request timer

[I.P.Knightly]

Re: [TESTING] OSI party request timer

Nevermind your first patch works i just added it in wrong area in PlayerMobile script anyways i can verify this patch works exactly like osi i just tested nice job.

Do you also get the option to eject a player from your house if they are there in it?

 

[Erica]

Re: [TESTING] OSI party request timer

Do you also get the option to eject a player from your house if they are there in it?

Nope don't have that option.

 

[Phoenix_Smasher7]

Re: [TESTING] OSI party request timer

Nevermind your first patch works i just added it in wrong area in PlayerMobile script anyways i can verify this patch works exactly like osi i just tested nice job.

Cool then. Lets see if we can get more testers so this little fix will go to TC faster

 

[I.P.Knightly]

Re: [TESTING] OSI party request timer

Nope don't have that option.

Maybe code that in now since it goes on the same gump?

 

[Phoenix_Smasher7]

Re: [TESTING] OSI party request timer

Any other context menu missing features?Currently eject player isn't in.I'll try to add it now.

 

[Phoenix_Smasher7]

Re: [TESTING] OSI party request timer

Alright this one should cover them both.

• Eject players entry will not show if the player is not a friend to house.
• Eject players entry will not kick staff members out of the house.
• Eject players entry will not work on mobile other than players.

 

[I.P.Knightly]

Re: [TESTING-TC] OSI party request timer

• Eject players entry will not show if the player is not a friend to house.

I don't understand this line

1st screen shot that house is public and that person is not a friend to that house all 3 options are there on the gump

2nd screen shot house is still public and I made him a friend to that house and all 3 options are there on the gump

 

[Phoenix_Smasher7]

Re: [TESTING-TC] OSI party request timer

With that line I meant that If a player isn't a friend or higher to house he/she wouldn't be able to see the context entry when they click on a player.

 

[uome]

Re: [TESTING-TC] OSI party request timer

IT was looking good, everything else seems to work as described but then there was a crash.
I used the "eject from house" button on someone:
They were not friended to the house.
The house was public.
They were inside the house.
I was outside the house.

Heres the report:

 Time: 21/12/2009 18:14:29
Mobiles: 3823
Items: 118392
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Server.ContextMenus.EjectPlayerEntry.OnClick()
   at Server.Network.PacketHandlers.ContextMenuResponse(NetState state, PacketReader pvSrc)
   at Server.Network.PacketHandlers.ExtendedCommand(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

Clients:
- Count: 3

*edit* Tested originaly on Demise TC, crash report from BAD TC.

 

[Athena]

Re: [TESTING-TC] OSI party request timer

I've removed this from the TC and I'll set it back to development.

 

[Phoenix_Smasher7]

Re: [IN DEVELOPEMENT] OSI party request timer

Hmm.I see the problem.Let me download the R483 and fix it there.

 

[Phoenix_Smasher7]

Re: [IN DEVELOPEMENT] OSI party request timer

Well I've fixed the checks.It should no longer crash because of invoking player returning null value on eject check.You should be able to eject someone as long as you see them in your house.Even from someone elses house.Though I didn't do extreme testing beyond that.I'll do the best I can if you break it again.

Tested on SVN 483.Also includes the party invitation entry.

 

[Athena]

Re: [TESTING-TC] OSI party request timer

TC updated

 

[[Demise]Yung]

Re: [TESTING-TC] OSI party request timer

Seems to be working, tried invinting a player from the context thingy on the character, and that worked, also was granted access to a house, was rejected from the character gump, worked as intended. Didn't work if I was friended to the house, but that should probably be as it should work.

 

[osd_daedalus]

Re: [TESTING-TC] OSI party request timer

I have ejected a guy succesfully from my house, either while I was in my house, and while I was outside my house, without crashing anything.
It's not possible to eject a friend.
When ejected, the targeted man can re-enter the house.

 

[I.P.Knightly]

Re: [TESTING-TC] OSI party request timer

You need to be able to eject a friend from your house as well.

 

[Phoenix_Smasher7]

Re: [TESTING-TC] OSI party request timer

Alright adding ejectable 'friends' then.

Edit: Is it related to any era?Because I see it's restricted under BaseHouse.

 

[Athena]

Re: [TESTING-TC] OSI party request timer

Setting back to development

 

[Phoenix_Smasher7]

Re: [IN DEVELOPMENT] OSI party request timer

Well holiday season you know how it is.Here's the kickable 'friends'.I've only set it to refrain from kicking only if core isn't ML.

 

[Athena]

Re: [TESTING-TC] OSI party request timer

TC updated.