osd_daedalus
Knight
Re: [VALIDATION NEEDED] Life-Mana leech and speed
just for readibility (RunUO devs insist on the fact is better a line of code more to improve it):
instead to use
I think is better
If you like, I can try to implement your code in a patch file, but I'd like also to add the "other" code, for the new values.
What else returns HML/HLL rather than weapons? According to your calculations, you need a weapon with more than 4s speed to have more than 100%. Now, on all of mace weapons, the slowest weapon is the war mace that has 4s (so it should return 100%). Slower weapons are archery ones, like bow (4.25s), but it's leeching is halved.
It's testable: craft in OSI lots of war maces and find the maximum intensity+speed bonus. I expect it's 100.
About bows... before or after? Go craft lots of runic heavy crossbows (5s) and see if the maximum percentage is 50% or 62-63% (the real value should be 62.5%)
just for readibility (RunUO devs insist on the fact is better a line of code more to improve it):
instead to use
Code:
if ( Core.AOS && !Core.ML ) [COLOR=Red]{statement 1}[/COLOR]
if ( Core.ML ) [COLOR=Red]{statement 2}[/COLOR]
Code:
if (Core.ML) [COLOR=Red]{statement 2}[/COLOR]
else if (Core.AOS)[COLOR=Red] {statement 1}[/COLOR]
Nottheking;646561 said:[edit]I just realized that the formula given above is for the MAXIMUM mana leech. So I'd have to adjust it, since it currently gives a result 50 times what it should. It also should have a cap at 100, so that needs to be added as well.
Also, another thing should be validated... Can you get higher than 50% leech value on a bow? We need to know if the 100% cap is applied before or after the halving for ranged weapons.
What else returns HML/HLL rather than weapons? According to your calculations, you need a weapon with more than 4s speed to have more than 100%. Now, on all of mace weapons, the slowest weapon is the war mace that has 4s (so it should return 100%). Slower weapons are archery ones, like bow (4.25s), but it's leeching is halved.
It's testable: craft in OSI lots of war maces and find the maximum intensity+speed bonus. I expect it's 100.
About bows... before or after? Go craft lots of runic heavy crossbows (5s) and see if the maximum percentage is 50% or 62-63% (the real value should be 62.5%)