[SVN] [gilgamash] Lightning Strike (Bushido)

[gilgamash]

Re: [IN DEVELOPMENT] Lightning Strike (Bushido)

Thanks to a discussion with Jeff yesterday I won't need any timer for this.

Hope to finish this one this evening so it can go into testing stage.

G.

 

[gilgamash]

Re: [IN DEVELOPMENT] Lightning Strike (Bushido)

Here we go:

1) I could not confirm the original problem any longer of losing mana when activating LS and running around. Tried for 15 minutes with all kind of weapons ans successive attacks. If you encounter the problem again, let me know!

2) The current patch thus reduces to change the siutation when the caster's mana due to whatever reason(s) drops below the minimum mana required for LS: According to OSI, as soon as this happens, the spell is cancelled.

G.

 

[Fana]

Re: [TESTING] Lightning Strike (Bushido)

what about the activation of Lightning strike, on demise you activate it... if you fail , it gets deactivated, and some ppl are saying on Osi it stays activated untill you actually hit.

also that lstrike bug, i used to notice even more when i activated the lstrikem fail itwhile walking and lose a huge amount of mana.

 

[gilgamash]

Re: [TESTING] Lightning Strike (Bushido)

what about the activation of Lightning strike, on demise you activate it... if you fail , it gets deactivated, and some ppl are saying on Osi it stays activated untill you actually hit.

also that lstrike bug, i used to notice even more when i activated the lstrikem fail itwhile walking and lose a huge amount of mana.

Hi Fana and thanks for your comments.

@#1: We would need someone to confirm the activation issue on OSI
@#2: Could you let me know how to reproduc it? It tried it both and demise and on my compiled Server and did not lose even one mana point when walking. I tried it while attacking and not attacking, holding swords, no weaps and archer stuff...

Thanks,
G.

 

[gilgamash]

Re: [TESTING-TC] [gilgamash] Lightning Strike (Bushido)

Hi again,

her comes the patch including the first one I posted. Now there should be no mana loss until the hit.

However, one question considering the code:

OnHit had to be changed such that now at this point validation and mana check including mana reduction happens. How do I have to handle the line

		public override bool ValidatesDuringHit { get { return false; } }

?

I do not call the validate function inside that, but I test for mana...

Regards,
G.

 

[Athena]

Re: [TESTING-TC] [gilgamash] Lightning Strike (Bushido)

The new patch gives the following error:

Errors:
+ Spells/Bushido/LightningStrike.cs:
CS0117: Line 34: 'Server.Mobiles.PlayerMobile' does not contain a definition
for 'ExecutesLightningStrike'
CS0117: Line 78: 'Server.Mobiles.PlayerMobile' does not contain a definition
for 'ExecutesLightningStrike'

Setting back to development.

 

[gilgamash]

Re: [IN DEVELOPMENT] [gilgamash] Lightning Strike (Bushido)

Ah, darn,

I forgot to include the PlayerMobile changes that were included in the last patch. Compiles at my computer, as I still have those changes active.

I will put in the complete patch tomorrow.

G.

 

[gilgamash]

Re: [IN DEVELOPMENT] [gilgamash] Lightning Strike (Bushido)

This should do the trick.

G.

 

[gilgamash]

Re: [TESTING] [gilgamash] Lightning Strike (Bushido)

And, anyone else than me up for testing it?

 

[Esqarrouth]

Re: [TESTING] [gilgamash] Lightning Strike (Bushido)

And, anyone else than me up for testing it?

previous post, my bad edited. it looks fine now

 

[Athena]

Re: [TESTING-TC] [gilgamash] Lightning Strike (Bushido)

TC updated.

 

[das3]

Re: [TESTING-TC] [gilgamash] Lightning Strike (Bushido)

Just gave this a quick test, seems to do fine.