[SVN] [Copern] code cleaning: scrolls of transc/105PS

[Bama]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

I have not received a SoT or 105PS in Bedlam today.

105's are not suppose to drop at non Fel champs I thought.Bedlam is Umbra Malas right?

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

105's are not suppose to drop at non Fel champs I thought.Bedlam is Umbra Malas right?

exact. Bedlam should only drop SoTs from 0.1 to 0.5, like Tokuno and Ilshenar

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

Index: Scripts/Misc/AutoSave.cs
===================================================================
--- Scripts/Misc/AutoSave.cs (revision 495)
+++ Scripts/Misc/AutoSave.cs (working copy)
@@ -7,7 +7,7 @@
{
public class AutoSave : Timer
{
- private static TimeSpan m_Delay = TimeSpan.FromMinutes( 5.0 );
+ private static TimeSpan m_Delay = TimeSpan.FromMinutes( 60.0 );
private static TimeSpan m_Warning = TimeSpan.Zero;
//private static TimeSpan m_Warning = TimeSpan.FromSeconds( 15.0 );

what is this??

 

[Fandul]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

just did neira in bedlam and no sots

 

[Copern]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

what is this??

Oh god, that would be an accident ... I changed the save timers on my own private shard and must have included it in the patch.

Just ignore that file when patching. I'll put up another patch without that.

Edit: And here it is without the auto-save change...

 

[Athena]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

TC updated.

 

[Copern]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

So I realized what's going on after we did the tests today... It looks like I got my patches mixed up and accidentally used a patch prior to the malas champ fix when I fixed the crash bug. Arrggg! Sorry about that guys.

Edit: I tried it out on my own server with drop rates increased and they are indeed dropping in malas now. So perhaps next time we'll get one.

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

During the DTCM, we did another champ in Bedlam, again with no scrolls.

In the suspect, I went just now to do an Ilshenar champ and got a SoT there.

Since it's at least the 4th Bedlam champ without a SoT there (normally you get at least 1 scroll every 2 champs), I think it's safe to tell Callandor2k's patch for Malas champ isn't working.

edit: ok Copern, now I understand why.

We wait this patch to be implemented, before testing this again plus seeing the functionality of other scrolls.

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

We wait for a TC update before continuing to test this.

 

[Athena]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

TC updated.

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

gotcha! 2 Trammish-SoTs in Bedlam.

Going to test the rest...

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

I think I have tested everything now. Tried either in DemiseTC and in a RunUO private distro.

- Tram SoT will spawn in Umbra champion spawns (Bedlam), Ilshenar and Tokuno
- Fel SoTs and 105 PS will spawn in Felucca, as Powerscrolls by killing champions, and stat scrolls by killing the Harrower. A knight of justice will have 100% of duplicates. Duplicates match with recovered PSes.
- All of scrolls work properly (PS and StatScrolls tested in private)
- Also Scrolls of Alacrity work properly (created as GM in private, they won't spawn in game)

Until this point, all is OK.

- About Copern's findings about "broken SoTs", I have tested the following:

• In DemiseTC, where I got a 0.9 Veterinary, I used it on a char with 119.6 Veterinary. The SoT disappeared and I got 0.4 points, for a total of 120.
• In private, I gave a 1.0 magery to a player with 99.7 magery. The scroll burned away and he got only 0.3 points. I haven't found any anomaly with [props or [skills.

Is this bug correctly tested? If yes, this patch is candidate for the SVN.
edit: previously, what was happening is the SoT not to disappear and instead to see a decrease in its value, while points NOT being applied. This is fixed so I say the whole patch is OK.

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

ready?

 

[Copern]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

- About Copern's findings about "broken SoTs", I have tested the following:

• In DemiseTC, where I got a 0.9 Veterinary, I used it on a char with 119.6 Veterinary. The SoT disappeared and I got 0.4 points, for a total of 120.
• In private, I gave a 1.0 magery to a player with 99.7 magery. The scroll burned away and he got only 0.3 points. I haven't found any anomaly with [props or [skills.

Is this bug correctly tested? If yes, this patch is candidate for the SVN.
edit: previously, what was happening is the SoT not to disappear and instead to see a decrease in its value, while points NOT being applied. This is fixed so I say the whole patch is OK.

Not quite what was wrong with them before. Did you try using the SoT when you were at your total skills cap and had 99.7 magery? If your total skills cap is 700 and you had 700 total skills with 99.7 magery then tried to use the 1.0 magery SoT... You wouldn't be able to use it and it would not add any skill which would be correct, but it would drop the skill value of the SoT to 0.7 (or 0.3, can't remember). With the patch it won't drop the skill value of the SoT if you can't use it in that situation.

 

[osd_daedalus]

Re: [TESTING-TC] [Copern] code cleaning: scrolls of transc/105PS

Not quite what was wrong with them before. Did you try using the SoT when you were at your total skills cap and had 99.7 magery? If your total skills cap is 700 and you had 700 total skills with 99.7 magery then tried to use the 1.0 magery SoT... You wouldn't be able to use it and it would not add any skill which would be correct, but it would drop the skill value of the SoT to 0.7 (or 0.3, can't remember). With the patch it won't drop the skill value of the SoT if you can't use it in that situation.

oh, understood.

Just tried now in DemiseTC:

I have a SoT 0.3 resisting spells
I have put 99.9 resist spells and other skills on myself to reach 720 total skill points.

I have tried to use the SoT and I wasn't able to: I got the message "make sure the skill is pointed up... if yes make sure you are not at the cap"

If I have pointed down some other skill, points are correctly detracted from the pointed down one.

Again, OK for me.

 

[Esqarrouth]

Re: [READY] [Copern] code cleaning: scrolls of transc/105PS

i didnt read all the posts, this is basically the same code just more organized right?

 

[osd_daedalus]

Re: [READY] [Copern] code cleaning: scrolls of transc/105PS

i didnt read all the posts, this is basically the same code just more organized right?

yes, with 2 little bugfixes but it's essentially the same thing.

 

[osd_daedalus]

Re: [READY] [Copern] code cleaning: scrolls of transc/105PS

Implemented in SVN 502

 

[osd_daedalus]

Re: [READY] [Copern] code cleaning: scrolls of transc/105PS

by Copern's and ASayre's notice, this one might be subject to revision on serializing methods, if confirmed.

 

[osd_daedalus]

Re: [READY] [Copern] code cleaning: scrolls of transc/105PS

by Copern's and ASayre's notice, this one might be subject to revision on serializing methods, if confirmed.

mmmmm... is it confirmed this one should return in Development for "better serializing" or this one can go in complete?