[SVN 662] Adding Salvage Bags

[atdp]

Re: [IN DEVELOPMENT] [P.Smasher] Adding Salvage Bags

Just seen on osi server that items bought from npc vendors always give 2 ingots no matter what. At 100 mining items crafted by players and items from killed monster corpses and items from dungeon chests give the same amount of ingots as the formula in the patch, also the number of ingots depends on the mining skill.

 

[atdp]

Re: [IN DEVELOPMENT] [P.Smasher] Adding Salvage Bags

Patch had a little mistake, here is fixed.

 

[Athena]

Re: [TESTING-TC] [P.Smasher] Adding Salvage Bags

TC updated.

 

[uome]

Re: [TESTING-TC] [P.Smasher] Adding Salvage Bags

Tested on BAD tc:

The scaling of ingot recovery on exceptionaly crafted smith items seems to work well now except if you are an elf and use the bag with 0 mining skill. This can produce what seems to be a -1 stack of ingots.
The ingot recovery of looted/npc items seems to work as intended.

As far as i can see everything else is working as it should.

 

[uome]

Re: [IN DEVELOPMENT] [P.Smasher] Adding Salvage Bags

I hope its ok but i have just been messing around with this one and i think i have solved the -ingots part.
Test please.

 

[UOHaloran]

Re: [TESTING-TC] Adding Salvage Bags

Here are my findings, if anything else related to the salvage bags needs to be tested just let me know. The -1 ingot issue seems to be fixed, as I cannot reproduce it.

0.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (2 ingots)
10.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (2 ingots)
20.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (2 ingots)
30.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (4 ingots)
40.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (6 ingots)
50.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (8 ingots)
60.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (10 ingots)
70.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (12 ingots)
80.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (14 ingots)
90.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (16 ingots)
100.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (18 ingots)
103.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (18 ingots)
105.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (18 ingots)
note: results were identical for human and elf; it seems the Jack of All Trades bonus is not in effect here

0 - 105.0 - Salvage bagged items purchased from an NPC vendor always give (2 ingots) in return

105.0 Mining - Smelted a crafted chainmail tunic (20 ingots) and recieved (10 ingots) as return
105.0 Mining - Smelted 3 crafted chainmail tunic (60 ingots) and recieved (30 ingots) as return

105.0 Mining - Salvage bagged a crafted chainmail tunic (20 ingots) and recieved (14 ingots) as return
105.0 Mining - Salvage bagged 3 crafted chainmail tunic (60 ingots) and recieved (42 ingots) as return

0.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (4 ingots)
10.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (4 ingots)
20.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (4 ingots)
30.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (5 ingots)
40.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (7 ingots)
50.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (9 ingots)
60.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (10 ingots)
70.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (12 ingots)
80.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (14 ingots)
90.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (15 ingots)
100.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (17 ingots)
103.0 Mining - Unable to obtain gloves
105.0 Mining - Unable to obtain gloves

0.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (2 ingots)
10.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (2 ingots)
15.0 Mining - Salvage bagged crafted platemail tunic (25 ingots) return is (3 ingots)
note: everything past 20.0 Mining is the same as human, I am assuming the Jack of All Trades bonus is what causes the difference
note: I was unable to obtain +5 Mining gloves so as a result I used 100.0 Mining for this test

0 - 100.0 - Salvage bagged items purchased from an NPC vendor always give (2 ingots) in return

100.0 Mining - Smelted a crafted chainmail tunic (20 ingots) and recieved (13 ingots) as return
100.0 Mining - Smelted 3 crafted chainmail tunic (60 ingots) and recieved (39 ingots) as return

100.0 Mining - Salvage bagged a crafted chainmail tunic (20 ingots) and recieved (14 ingots) as return
100.0 Mining - Salvage bagged 3 crafted chainmail tunic (60 ingots) and recieved (42 ingots) as return
note: I was unable to obtain +5 Mining gloves so as a result I used 100.0 Mining for this test

I tried to present this as best I could without cluttering the board too much. I hope it's useful.

 

[KickerofAssets]

Re: [TESTING-TC] Adding Salvage Bags

When I used the bag, it asked for scissors to be also in my pack. Is that normal?

Also, It only gave me an option for cutting up leather armor as "cloth". Don't know if that is normal either instead of calling it a generic Tailor/Smith/Mining as options.

I do not use osi so I am just curious.

 

[uome]

Re: [TESTING-TC] Adding Salvage Bags

When I used the bag, it asked for scissors to be also in my pack. Is that normal?

Also, It only gave me an option for cutting up leather armor as "cloth". Don't know if that is normal either instead of calling it a generic Tailor/Smith/Mining as options.

I do not use osi so I am just curious.

As far as i know this is all correct.

Here are my findings, if anything else related to the salvage bags needs to be tested just let me know. The -1 ingot issue seems to be fixed, as I cannot reproduce it.

I tried to present this as best I could without cluttering the board too much. I hope it's useful.

Thanks for the testing.
I have revised the formula to reflect your osi findings when salvaging platemail tunics. I hope this all works now.
Joat was being taken into consideration but because the formula was off it was not showing up.

Here is a new patch.

 

[Athena]

Re: [TESTING-TC] Adding Salvage Bags

TC Updated.

 

[bacchus1234]

Re: [TESTING-TC] Adding Salvage Bags

Is the salavage bag suppose to give +1 extra ingot when smelting?

On TC I crafted a normal Bronze Shield
when smelted without bag, yields 6 ingots (same on demise)
when smelted with bag, yields 8 ingots

testing at 100 mining skill

 

[uome]

Re: [TESTING-TC] Adding Salvage Bags

Here are my findings, if anything else related to the salvage bags needs to be tested just let me know. The -1 ingot issue seems to be fixed, as I cannot reproduce it.

Smelt/Salvage Discrepancy Demise
105.0 Mining - Smelted a crafted chainmail tunic (20 ingots) and recieved (10 ingots) as return
105.0 Mining - Smelted 3 crafted chainmail tunic (60 ingots) and recieved (30 ingots) as return

105.0 Mining - Salvage bagged a crafted chainmail tunic (20 ingots) and recieved (14 ingots) as return
105.0 Mining - Salvage bagged 3 crafted chainmail tunic (60 ingots) and recieved (42 ingots) as return

Smelt/Salvage Discrepancy osi
100.0 Mining - Smelted a crafted chainmail tunic (20 ingots) and recieved (13 ingots) as return
100.0 Mining - Smelted 3 crafted chainmail tunic (60 ingots) and recieved (39 ingots) as return

100.0 Mining - Salvage bagged a crafted chainmail tunic (20 ingots) and recieved (14 ingots) as return
100.0 Mining - Salvage bagged 3 crafted chainmail tunic (60 ingots) and recieved (42 ingots) as return
note: I was unable to obtain +5 Mining gloves so as a result I used 100.0 Mining for this test

Is the salavage bag suppose to give +1 extra ingot when smelting?

On TC I crafted a normal Bronze Shield
when smelted without bag, yields 6 ingots (same on demise)
when smelted with bag, yields 8 ingots

testing at 100 mining skill

It looks like there may be something wrong with smelting on Demise based on what was posted by UOHaloran.
I have no idea if a seperate report was made for the smelting differences.

 

[Athena]

Re: [TESTING-TC] Adding Salvage Bags

I think to avoid confusion the smelting differences between Demise and OSI needs to be looked at and fixed before this can be implemented, just to be sure that the smelting is correct using the bag. It can either be fixed along with this thread or posted as a seperate bug report.

 

[osd_daedalus]

Re: [TESTING-TC] Adding Salvage Bags

I think to avoid confusion the smelting differences between Demise and OSI needs to be looked at and fixed before this can be implemented, just to be sure that the smelting is correct using the bag. It can either be fixed along with this thread or posted as a seperate bug report.

So, looks like we have to do the same thing we did for tailoring here.

http://www.uodemise.com/forum/showthread.php?t=120231

*shrugs* this will require some time in OSI to understand all the salvage mechanism (meaning by smelting, not by salvage bag). I bet it's a "category" scheme like for tailorables.

 

[Bama]

Re: [TESTING-TC] Adding Salvage Bags

Maybe a problem?
http://www.uodemise.com/forum/showthread.php?p=812820#post812820

 

[uome]

Reuploaded (is that a word?) the previous patch.

 

[Ageless Venomous]

Tested. Everything working properly. Except:

Does salvage bag considers smithing hammers as blacksmithing tools on OSI? In my tests, hammers were not considered as blacksmith tools, so the salvage bag could not be used.

With tongs, the bag smelted the items properly.

PS: Did not test the scaling of smelting items X ingots recieved.

 

[Bama]

If the salvage bag does not recognize a smith hammer as a smelting tool then you have a problem
Another thing to watch for is a smelting tool or scissors can not be in the salvage bag for it to work (as per osi)

 

[uome]

Does salvage bag considers smithing hammers as blacksmithing tools on OSI? In my tests, hammers were not considered as blacksmith tools, so the salvage bag could not be used.

This is probably something to do with the way the smith hammer weapon patch on the tc atm works. I just checked on my local tc and all smith tools worked ok.

 

[xtraorange]

I'm sorry if this is a stupid question, is this file available for download or strictly for Demise? My friends on my private server were hoping that I would add the salvage bag.

Thank you.

 

[osd_daedalus]

I'm sorry if this is a stupid question, is this file available for download or strictly for Demise? My friends on my private server were hoping that I would add the salvage bag.

Thank you.

It's in the RunUO SVN, just update your shard. (because you are using the SVN version, right? Otherwise follow these instructions)