[COMPLETE] No HCI on runic crafted shields

[gilgamash]

[COMPLETE] No HCI on runic crafted shields

Greets,

can't test it right now, but should basically work. If it does, I guess players will hate me.

--- devel/Scripts/Items/Skill Items/Tools/BaseRunicTool.cs      (revision 321)
+++ devel/Scripts/Items/Skill Items/Tools/BaseRunicTool.cs      (working copy)
@@ -477,6 +477,8 @@
                                m_Props.Set( 3, true ); // remove mage armor from possible properties
                        if ( armor.Resource >= CraftResource.RegularLeather && armor.Resource <= CraftResource.BarbedLeather )
                                m_Props.Set( 0, true ); // remove lower requirements from possible properties for leather armor
+                       if ( isShield && Core.ML )
+                               m_Props.Set( 2, true);  // remove HCI from shields as possible property

                        for ( int i = 0; i < attributeCount; ++i )
                        {

 

[Nikki_Demise]

Re: No HCI on runic crafted shields

If it does, I guess players will hate me.

I will gladly turn that dubious honor over to you. lol

 

[uome]

Re: No HCI on runic crafted shields

Tested slightly, so far the results are:

any existing shields were not affected.
I made several different shields with different metals using a valorite hammer, no hci appeared.
50 or so df's killed with high luck, no shields with hci appeared as loot. Is this right?
weapons still appear with hci.

 

[gilgamash]

Re: No HCI on runic crafted shields

Greets and thanks a he** of a lot for such exhaustive testing!

It was supposed to behave like this, yes. I was not sure whether the changes done even affected LOOT shields, but have not been able so far to find other sources generating shields. HCI is supposed to not at all show up on any new shields any longer, be they crafted or not.

G.

 

[uome]

Re: No HCI on runic crafted shields

based on this:
http://www.uodemise.com/forum/showpost.php?p=562435&postcount=5
I should be seeing rpd on shields as a replacement for hci but so far havn't.

 

[gilgamash]

Re: No HCI on runic crafted shields

I'll have a look into it

 

[gilgamash]

Re: No HCI on runic crafted shields

k, substituted the RPD for the HCI attribute.

--- Scripts/Items/Skill Items/Tools/BaseRunicTool.cs    (revision 321)
+++ Scripts/Items/Skill Items/Tools/BaseRunicTool.cs    (working copy)
@@ -477,7 +477,6 @@
                                m_Props.Set( 3, true ); // remove mage armor from possible properties
                        if ( armor.Resource >= CraftResource.RegularLeather && armor.Resource <= CraftResource.BarbedLeather )
                                m_Props.Set( 0, true ); // remove lower requirements from possible properties for leather armor
-
                        for ( int i = 0; i < attributeCount; ++i )
                        {
                                int random = GetUniqueRandom( baseCount );
@@ -492,7 +491,7 @@
                                                /* Begin Sheilds */
                                        case  0: ApplyAttribute( primary,       min, max, AosAttribute.SpellChanneling,                 1, 1 ); break;
                                        case  1: ApplyAttribute( primary,       min, max, AosAttribute.DefendChance,                    1, 15 ); break;
-                                       case  2: ApplyAttribute( primary,       min, max, AosAttribute.AttackChance,                    1, 15 ); break;
+                                       case  2: ApplyAttribute( primary,       min, max, AosAttribute.ReflectPhysical,                 1, 15 ); break;
                                        case  3: ApplyAttribute( primary,       min, max, AosAttribute.CastSpeed,                               1, 1 ); break;
                                                /* Begin Armor */
                                        case  4: ApplyAttribute( secondary,     min, max, AosArmorAttribute.LowerStatReq,               10, 100, 10 ); break;

The lines excluding the property 2 are thus deleted again now.

G.

 

[uome]

Re: No HCI on runic crafted shields

I don't see any if core.ML in there or am i missing something?

 

[gilgamash]

Re: No HCI on runic crafted shields

To clarify it: for non-ML we want to keep HCI?

 

[uome]

Re: No HCI on runic crafted shields

Looking at what i can find, yes i think we do.

 

[gilgamash]

Re: No HCI on runic crafted shields

So let's try this here

===================================================================
--- Scripts/Items/Skill Items/Tools/BaseRunicTool.cs    (revision 321)
+++ Scripts/Items/Skill Items/Tools/BaseRunicTool.cs    (working copy)
@@ -477,7 +477,6 @@
                                m_Props.Set( 3, true ); // remove mage armor from possible properties
                        if ( armor.Resource >= CraftResource.RegularLeather && armor.Resource <= CraftResource.BarbedLeather )
                                m_Props.Set( 0, true ); // remove lower requirements from possible properties for leather armor
-
                        for ( int i = 0; i < attributeCount; ++i )
                        {
                                int random = GetUniqueRandom( baseCount );
@@ -492,7 +491,13 @@
                                                /* Begin Sheilds */
                                        case  0: ApplyAttribute( primary,       min, max, AosAttribute.SpellChanneling,                 1, 1 ); break;
                                        case  1: ApplyAttribute( primary,       min, max, AosAttribute.DefendChance,                    1, 15 ); break;
-                                       case  2: ApplyAttribute( primary,       min, max, AosAttribute.AttackChance,                    1, 15 ); break;
+                                       case  2:
+                                               if (Core.ML) {
+                                                   ApplyAttribute( primary,    min, max, AosAttribute.ReflectPhysical,                 1, 15 );
+                                               } else {
+                                                   ApplyAttribute( primary,    min, max, AosAttribute.AttackChance,                    1, 15 );
+                                               }
+                                               break;
                                        case  3: ApplyAttribute( primary,       min, max, AosAttribute.CastSpeed,                               1, 1 ); break;
                                                /* Begin Armor */
                                        case  4: ApplyAttribute( secondary,     min, max, AosArmorAttribute.LowerStatReq,               10, 100, 10 ); break;

 

[uome]

Re: No HCI on runic crafted shields

<psz:snip>
Anyway tested as before and all looks good.

allready created shields are not afected.
hci still appeasr on weapons.
rpd appears on crafted and looted shields, capped at 15%
hci no longer appears on crafted an looted shields.

 

[WarUO]

Re: No HCI on runic crafted shields

There will always be HCI shields the same way it is on OSI the current shields with HCI do not get modified in any way.

 

[Vykintas]

Re: No HCI on runic crafted shields

Question. If I have a shield with 15hci, after update there will be no hci on it??

 

[osd_daedalus]

Re: No HCI on runic crafted shields

There will always be HCI shields the same way it is on OSI the current shields with HCI do not get modified in any way.

as many "rare" and expensive items in OSI, yes. HCI shield that are in Demise before this patch will continue to exist after this patch.

Question. If I have a shield with 15hci, after update there will be no hci on it??

as it's above and below

So shields with hci now = will be abusively valuable in the future.

 

[hickman48]

Re: No HCI on runic crafted shields

as a noted the no hci on shields was added cuz of the faction items you can get 45 hci with faction vile grips and tally then with brec and shiled you will be well above the hla without the new necks or head pice it was just another nef osi added for mele dexxors since mages get 25 dci glasses a sc no pen shiled with 15 15

 

[LadyCrimson]

Re: No HCI on runic crafted shields

I wonder how many runics are being burned on shields at this very moment....

 

[osd_daedalus]

Re: No HCI on runic crafted shields

I wonder how many runics are being burned on shields at this very moment....

I tried to stop myself to say "speculate on them now!", but I was thinking the same

 

[uome]

Re: No HCI on runic crafted shields

I wonder how many runics are being burned on shields at this very moment....

I did it days ago.
Now my house has 11 storage left


*EDIT* btw gilgamash, your patch was missing an index line at the top.
That had me stumped for a while

 

[gilgamash]

Re: No HCI on runic crafted shields

*EDIT* btw gilgamash, your patch was missing an index line at the top.
That had me stumped for a while

Oops, sorry for that, pal. Well, looks like pple are panicing .-) I did not burn a single runic use so far....

G.