[SVN 672] Honour Virtue Bugs

[Feersum Endjinn]

Re: [TESTING] Virtue Bugs

But things get complicated.

OSI - 5th to 6th dot. Ettins:

Invoke Honor
Not moving
Getting hit first
No pet
No poison
50 kills to fill that 1 dot

FE

 

[Feersum Endjinn]

Re: [TESTING] Virtue Bugs

OSI - 6th dot to 7th dot:

The only way to gain is to do as the guide says [for 100% honourable combat].
Anything other then that you will not gain.( a tamers would not gain at this level )
I am at 68 honor kills this way and have not made it to the 7th dot.

FE

 

[Feersum Endjinn]

Re: [TESTING] Virtue Bugs

Personally, I think it might be a good idea to put in a fix for the urgent and easy aspects right now (Aggressive monsters should attack you, Honour shouldn't decay over time, coinciding gumps and msgs, confirmation gump for Embracing Honor if this is verified etc) and then put the rest back to "In development" for now.

Just wanted to re-state my thinking on this, given the urgent need for the aggroed mobs fix and the complexity of actually working out how Honour gain works on OSI.


FE

 

[adverserath]

Re: [TESTING] Virtue Bugs

moving and not hitting from 1 tile away = 20% less (not affected by pets)

having first hit = 35% less

using pet/summon = 30% less

no idea on that last post FE. was a constant 31 kills for the first 5?

 

[adverserath]

Re: [TESTING] Virtue Bugs

maybe the fame is calculated as
newfame=fame-honor

so at 2800 (7th dot)you are gaining 2 honor as the fame would be 200.

this way you can get seeker by killing hiryus quickly, but killing ettins (or something similar with more than 4000 fame) would be very slow.
this way it doesnt make it really easy for people.

 

[adverserath]

Re: [IN DEVELOPMENT] Virtue Bugs

what needs to be fixed then?
the honor gain, and remove "i honor you"

we need to know exactly how much honor is gained, and how this slows down as we progress in the virtue.

 

[silvertiger]

Re: [IN DEVELOPMENT] Virtue Bugs

what needs to be fixed then?
the honor gain, and remove "i honor you"

we need to know exactly how much honor is gained, and how this slows down as we progress in the virtue.

core check.

 

[adverserath]

Re: [IN DEVELOPMENT] Virtue Bugs

thats less dots than i have set, i think its currently a 10% loss, but that would be 5%. Not sure on the duration. Ill need to look at the code.

 

[Feersum Endjinn]

Re: [TESTING] Virtue Bugs

Ok. I have updated the post below with all the new verified info.

Would it be possible to a) change the title to "Honour Virtue Bugs" and b) make the post below (now somewhere on page two...) the first post in the thread for ease of use?

This is a complex fix with 11 different possible bugs now...

Thanks

FE

Oki, fist of all - thanks a bunch for getting this fix moving, Adverserath

There are a few things I am worried about though - Maybe the most important is #2. - this requires an urgent fix!

Here is a list of the known problems with Honour:

• 1. Honour should not decay with time - only when you Embrace Honour.

Verified. Fixed by Ad.

• 2. Any creature already aggressive to you before you Embrace Honour or any creature you attack while Embracing Honour should attack you back.

Verified and also verified (by me ) that this is not the case on Demise right now: if you hit a monster it will hit you back - but then it just continues to wander around in a non aggressive state.

Urgent Fix needed.

• 3. Embracing Honour should cost blue dots.

OSI verified, but: How many blue dots do you lose? Do you always lose the same number of dots (using it from Knight, using it from Seeker etc). Update: from Knight you lose one dot on use on OSI and on Demise. Verification needed for Seeker and Follower.

Possibly Fix Needed

• 4. Virtue Circle Gump, Status scroll and blue dots should coincide to show the same (correct) level of Honour and give the correct messages when you gain honour.

Verified. Fixed by Ad.

• 5. On OSI there is no message "You honour your foe" - only messages explaining why you have NOT been able to honour it.

Verified by I.P.

Fix needed.

• 6. You get a "Yes/No" confirmation gump when you Embrace Honour on OSI.

Verified by IPK.

Fix needed.

• 7. On OSI an "Honourable Battle" does not end when you move 1 screen away or die, but rather only "when the battle ends" 30-40 minutes later.

Verified by IPK.

Fixed by adverserath.

• 8. On OSI Embracing Honour lasts longer. (+/- 20mins at Knight)

Verified by IPK. Verification of duration at Follower and Seeker Needed

Fix Needed

• 9. On OSI all creatures can give honour until their Fame is matched.

Verified by adverserath.

Fix in progress by adverserath but numbers need verifying

• 10. Archers, Mages and Tamers can gain honour albeit much more slowly than Melee Fighters.

Verified - UOHerald. But we need OSI verification on exactly how slowly compared to Melee Fighters.

Fix in progress by adverserath but numbers need verifying

• 11. The amount of Honour you gain depends on how closely you stick to the rules of combat:

Verified. But definitely Needs OSI verification on how this actually works.

• a) How much honour (how many dots at each level) you get from each Fame point of a vanquished monster. I.P.s research seems to suggest that it is far less on OSI.

• b) How much less honour you get for each rule you break and especially how much less you get for using a pet. I.P.s research seems to suggest that it is far less on OSI.

I believe this actually can be verified reasonably easily. A melee char should kill a creature with an established Fame level following all the rules and see how many dots he gets. Ideally he should then repeat this various times to confirm the same amount is given all the way through each level and to make it easier to see cases of "1.5 dots per monster".

The same char should then use up all his honour by Embracing Honour and then test again ignoring one of the rules, then ignoring two of the rules, etc.

Finally he should test ignoring all the rules except actually honouring his foe.

The same process should then be tested using magery, ranged weapons and finally (and most important) a pet.

I know this sounds like overkill - but just arbitrarily giving x honour is just plain wrong. So is arbitrarily giving Mages x% and Tamers y% without verification. Doing it like this it will never get implemented by Mark and the Dev team.

Stay Safe

FE

Personally, I think it might be a good idea to put in a fix for the urgent and easy aspects right now (Aggressive monsters should attack you, Honour shouldn't decay over time, coinciding gumps and msgs, confirmation gump for Embracing Honor if this is verified etc) and then put the rest back to "In development" for now.

Oh, and maybe Athena could change the title to "Honour Virtue Bugs" - I will post another report for the other Virtues when I have a moment.

 

[Athena]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

I've changed the title of the thread but we're not able to move individual posts to the start of the thread, you'll have to edit your initial bug report if you want it at the start.

 

[Ryne-Demise]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

• 10. Archers, Mages and Tamers can gain honour albeit much more slowly than Melee Fighters.

Verified - UOHerald. But we need OSI verification on exactly how slowly compared to Melee Fighters.

Fix in progress by adverserath but numbers need verifying

*********

I made some tests with my pet Hiryu in OSI;

Honor status: Follower (2 dots)

First of all, I have embraced honor on myself 2 times and every time I've lost 1 dot. So, I was basically planning to start testing with zero dots in follower status.

Each embrace lasted for 1 min. 31 sec.
Honor recast delay : 5 mins

and became as;

Honor status: Follower (no dots)

Ettins : No gain
Ogres : No gain
Ogre Lords : Got first dot after 6 kills. So, dots aren't saying everything. There was some invisible points accumulated in follower status and we can't see them.

Ogre Lords : Got second dot after 50 kills.

Sphynx (same fame as ogre lords) : Got third dot after 111 kills.

And believe me it was veeery boring test I think there is a curve but I'm not sure if it's linear or logarithmic.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

was that total of kills or kills between each dot?

 

[Ryne-Demise]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

was that total of kills or kills between each dot?

It was kills between each dots.. Total kills from zero dot in follower to 3 dots = 167

(6+50+111)

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

just gave it a quick look over. A lot of verification is needed.

i can clean up the code to add:

0. (not noted in fix list) tamer was not awarded honor, the pet was. now tamers can gain at least some honor.

- else if ( from is BaseCreature && ((BaseCreature)from).GetMaster() == from )
+ else if ( from is BaseCreature && ((BaseCreature)from).GetMaster() == m_Source )

1. Honour should not decay with time - only when you Embrace Honour.

2. Any creature already aggressive to you before you Embrace Honour or any creature you attack while Embracing Honour should attack you back.

4. Virtue Circle Gump, Status scroll and blue dots should coincide to show the same (correct) level of Honour and give the correct messages when you gain honour. and all other virtues

7. On OSI an "Honourable Battle" does not end when you move 1 screen away or die, but rather only "when the battle ends" 30-40 minutes later.​

not yet fixed:

3. Embracing Honour should cost blue dots.
(how many)

5. On OSI there is no message "You honour your foe" - only messages explaining why you have NOT been able to honour it.
(guess this one is easy)

6. Gump when embracing
i Have no idea about the gump message. Ill have to find out what it looks like, and have a go making a gump message.

8. On OSI Embracing Honour lasts longer
(need to know how much longer)

9. On OSI all creatures can give honour until their Fame is matched.
(seems reasonable, but doesnt always seem to be the case)
maybe we should consider that it isnt the level of honor changed with the rules, but it could be the fame of the monster, the honor may be a direct calculation from the fame

10. Archers, Mages and Tamers can gain honour albeit much more slowly than Melee Fighters.
11. honor rules
(this is the most painful fix yet)​

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

i know this is probably the least fun to validate and could take hundreds of man hours. Can we implement a system that is just closer to osi honor than the one we currently use? We could then refine it later on?

 

[Bama]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

This gets more complicated
A provoke bard can gain in Honor
I know it can be done.
Fred Norris/Glxwil can confirm it 100% because he plays a Provoke/Tamer who is a knight or was a knight of Honor on osi
He can also confirm that at knight of honor when you use the virtue it will cost you 1 blue dot that lasts 20 minutes

I am not sure how it works on demise but on osi different class fighters gain different amounts of fame though the same amount of karma

I did some testing with a dexxer and with a bard
Started with 0 fame and karma and killed 4 ettins each

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

so i was right, its the fame that must change. i might do a test on osi myself next week. if i kill something with 300 fame i should be able to get the first dot using a warrior and a tamer.i can then base the differences on honor gains on the difference of this. Or at least that is the plan. I might as well try a mage too.

 

[adverserath]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

from bamas post to me.

This Honour (did you like that Honour not Honor ) Virtue you are working on I think osi has given us a nice working tool to support your theory
On osi now we have fame/karma gumps which tell us every fame and karma point we gain

The other day on osi I sacrificed my fame and kept hunting and out of curiosity I checked how much fame a daemon gave
With zero fame points after killing the daemon I got 150 fame points
The next daemon yielded 149 points

Do you think this info with more data can help you with the following?

9. On OSI all creatures can give honour until their Fame is matched.
(seems reasonable, but doesnt always seem to be the case)
maybe we should consider that it isnt the level of honor changed with the rules, but it could be the fame of the monster, the honor may be a direct calculation from the fame

I had a theory on this a while ago. The more your fame, the less the honour.
if your fame is 150 you gain 149
if you fame is 14000, are the gains very slow? 10 or something?

here is what i can work out
I have a feeling we might have a formula to look at.

(monsters fame(15000)-your fame(0))/ 100
150

if you fame was 1000, you would only gain 140.
if this number then works in honour it would be constantly reducing the gains as fame increases. Does sacrificing fame constantly while gaining honor speed up honor gains?

 

[glxwill]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

Just adding some verification screenshots for provocation gaining honor.

 

[Ryne-Demise]

Re: [IN DEVELOPMENT] Honour Virtue Bugs

8. On OSI Embracing Honour lasts longer

(need to know how much longer)

​

Honor yourself with max. honor (knight of honor) in Demise costs 1 blue dot and gives 5 minutes

while Bama says for OSI;

Fred Norris/Glxwil can confirm it 100% because he plays a Provoke/Tamer who is a knight or was a knight of Honor on osi
He can also confirm that at knight of honor when you use the virtue it will cost you 1 blue dot that lasts 20 minutes