[SVN] Changes need to blacksmith crafting tools.

[Athena]

[SVN] Changes need to blacksmith crafting tools.

Behavior on Demise: You cannot open the blacksmith gump from the blacksmith tools away from a forge or anvil.

Behavior on OSI: You can double click the blacksmith tools to view the gump, and the message to use it near a forge and anvil only appears if you try to craft away from a forge or anvil. This message appears in the gump on OSI, on demise it shows as a localized message.

Supporting Documentation (URLs): None needed, I verified this on OSI myself.

Changes needed: Change the blacksmith tools so they can be used away from forges and anvils but not able to actually craft unless near a forge or anvil.

Code (optional): None

This screenshot was taken by britain moongate, you can see the anvil/forge message in the actual gump.

View attachment 15991

 

[Copern]

Re: [CODER NEEDED] Changes need to blacksmith crafting tools.

I think before AOS and during AOS you actually had to be near a forge and anvil to open the gump. I think this was a change for SE or ML, but I don't really remember. If any one can tell me otherwise I'll change it. For now, here's a patch.

 

[Erica]

Re: [TESTING] Changes need to blacksmith crafting tools.

Can confirm this heres a picture i just took a second ago on osi no where near a anvil.

 

[Copern]

Re: [TESTING] Changes need to blacksmith crafting tools.

Teeny weeny change. Doesn't affect anything but I was calling an end action for an action that never began anyway. I moved it's position in the Craft method at one point and forgot to remove the EndAction line.

 

[osd_daedalus]

Re: [TESTING] Changes need to blacksmith crafting tools.

if ( Core.Expansion <= Expansion.AOS )

isn't good just if (Core.AOS) ?

 

[Copern]

Re: [TESTING] Changes need to blacksmith crafting tools.

Uhh... thinking about that !Core.SE should work fine. I'm not sure why I did it that way.

 

[osd_daedalus]

Re: [TESTING] Changes need to blacksmith crafting tools.

oh right sorry, haven't seen the <= ... hehe I'm tired

Yes, !Core.SE should work. Let's have a look... (uome? )

 

[uome]

Re: [TESTING] Changes need to blacksmith crafting tools.

Should i be able to smelt, repair and enhance away from an anvil and forge because atm with this patch i can?

 

[Copern]

Re: [TESTING] Changes need to blacksmith crafting tools.

I don't think you are supposed to be able to. Will look into that.

 

[Copern]

Re: [TESTING] Changes need to blacksmith crafting tools.

Alright this should give the proper messages when trying to smelt, enhance, or repair items away from a forge and anvil. This should also fix the problem of being able to wander away from the forge/anvil on SVN and still being able to smelt, enhance, or repair. Of note is the "You must be near a forge and and anvil to repair items" message. Yes, there's two and's in it.

 

[uome]

Re: [TESTING] Changes need to blacksmith crafting tools.

I can't find anything wrong with this one.

I cannot craft, enhance or repair away from an anvil and forge.
I cannot move too far away from the forge with the gump open and craft, repair or enhance.
I cannot use a fire beetle and an unsecured coloured anvil to craft on.
The messages appear exactly as shown in the screenshot provided.
Tested with runic tools and dragon scale also.
Nice job

 

[Hilde]

Re: [TESTING] Changes need to blacksmith crafting tools.

I can't find anything wrong with this one.

I cannot craft, enhance or repair away from an anvil and forge.
I cannot move too far away from the forge with the gump open and craft, repair or enhance.
I cannot use a fire beetle and an unsecured coloured anvil to craft on.
The messages appear exactly as shown in the screenshot provided.
Tested with runic tools and dragon scale also.
Nice job

I can 2nd that. Also tried locked down forge and fire beetle and it still didn't work.

 

[uome]

Re: [TESTING] Changes need to blacksmith crafting tools.

ready?

 

[osd_daedalus]

Re: [READY] Changes need to blacksmith crafting tools.

Implemented in SVN 437