[SVN] bless buff icon inaccuracy

[Gisela]

[SVN] bless buff icon inaccuracy

Behavior on Demise: The bless spell is less effective than its displayed value in the buff bar
Behavior on OSI: unknown
Supporting Documentation (URLs): none
Changes needed: find the correct formula for stat bonuses based on eval
Code (optional):

I've observed lots of fishy things with this spell and can't put my finger on the part of the code that is broken.

1- the buff is not removed until you perform some action like walk around
2- the buff cannot be refreshed (you have to wait for it to wear off)
3- the displayed evalint bonus actually gets WORSE at 120 eval
4- sometimes the buff icon doesn't appear at all
5- sometimes the stat change remains even after the buff has run out

On my home test server:

A char with 100 eval gets an 11% bonus applied, but the buff icon says they are getting 16%.

A char with 110 eval gets gets a 12% bonus applied, but the buff icon says they are getting 17%.

A char with 115 eval gets a 12% bonus applied, but the buff icon says they are getting 17%

A char with 120 eval gets a 13% bonus applied, but the buff icon says they are getting 18%

Now this is weird:

My demise char with 120 eval gets a 12% bonus and the buff icon says she is getting 10%

 

[psz]

Re: Multiple problems with the bless spell

Please please please use the form.

Makes it much easier to read the main issue ;->

 

[Gisela]

Re: Multiple problems with the bless spell

Oops

 

[osd_daedalus]

Re: Multiple problems with the bless spell

it could also be the buff infos are wrong

Who see this in OSI?

 

[Gisela]

Re: [VALIDATION NEEDED]Multiple problems with the bless spell

Yeah I just found it. When the bufficon value is being calculated, bool curse = true is set, which is wrong. This is a buff, not a curse. That would explain why my demise char displays even less: she has high magic resist.

It seems the bufficon bug is only cosmetic.

Bah. I'd still like to verify they are getting the proper bonus

 

[Gisela]

Re: [VALIDATION NEEDED]Multiple problems with the bless spell

I found this info on stratics

http://uo.stratics.com/content/guides/magic.shtml

which leads me to believe that our evalint bonus is in fact correct.

So here is the bufficon fix.

Index: Scripts/Spells/Third/Bless.cs
===================================================================
--- Scripts/Spells/Third/Bless.cs    (revision 369)
+++ Scripts/Spells/Third/Bless.cs    (working copy)
@@ -42,7 +42,7 @@
                 m.FixedParticles( 0x373A, 10, 15, 5018, EffectLayer.Waist );
                 m.PlaySound( 0x1EA );
 
-                int percentage = (int)(SpellHelper.GetOffsetScalar(Caster, m, true) * 100);
+                int percentage = (int)(SpellHelper.GetOffsetScalar(Caster, m, false) * 100);
                 TimeSpan length = SpellHelper.GetDuration(Caster, m);
 
                 string args = String.Format("{0}\t{1}\t{2}", percentage, percentage, percentage);
@@ -76,4 +76,4 @@
             }
         }
     }
-}
\ No newline at end of file
+}

 

[osd_daedalus]

Re: [TESTING] bless buff icon inaccuracy

Tested:

pre-patch: my stats raised of 3%, but percentages indicated on bless buff icon are affected by Resist Spells and messed up (+8% at 0 resist spells, +0% at 120 resist spells)

post-patch: percentages are not influenced anymore by magic resist, and they correspond to the effective increase of stats. (3%)

The effective gain in stats got no influenced in any way, it is the same as before.

I say it's OK for me.
file:///C:/Documents and Settings/Deda/Documenti/Download/morphs.diff

 

[uome]

Re: [TESTING] bless buff icon inaccuracy

ready?

 

[psz]

Re: [TESTING] bless buff icon inaccuracy

I don't trust Daed, so I'm waiting on you, uome.






;->

 

[osd_daedalus]

Re: [TESTING] bless buff icon inaccuracy

I don't trust Daed, so I'm waiting on you, uome.

Trust on the SVN 437 then! =D